fix(vite): Fix CSS replacement in Vite HMR #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2e4e227 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Also remove dependency on @rollup/plugin-utils
Anber
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove dependency on @rollup/plugin-utils
Motivation
This PR fixes an issue related to Vite plugin originally opened on Pigment CSS repo.
Summary
This change avoids the usage of css content slug in the filename and keeps the css filename unique just by using the path of the original js/ts file and using
wyw-in-jsprefix before the extension.Using slug had an issue where if you removed a css property from your css definition, it would get applied in a new
styletag during dev mode. Thus also keeping the old css in place which would result in overall css being applied from both old and new css content.The fix instead keeps using the same filename regardless of the content and just pings the FE to reload the latest CSS content which it replaces in the existing
styletag instead of adding a new one.I also removed the explicit dependency of @rollup/plugin-utils since
vitealready re-exports those.Test plan
Tested locally using this repo for the bug reproduction and fix.